Offer named clients when routing, not just apps - #24
Merged
Conversation
The route list's + opened an application picker, which cannot find a daemon: a FaceTime call belongs to avconferenced, which has no .app, so the only way to route it was a line in config.json by hand. Every client meeting detection names now lands in an in-memory list, newest first, and once that list has anything in it the + becomes a menu: "Choose Application…" first, then those clients by name. Picking one skips the app picker and asks only for the folder. In memory only and a snapshot at open, like the rest of the Settings model, so the list starts empty at each launch — the README says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #23. The route list's
+opened an application picker, which cannot find a daemon — a FaceTime call belongs toavconferenced, which has no.app— so the only way to route one was a hand-written line inconfig.json.Every client meeting detection names goes into an in-memory list (newest first, deduplicated by identifier). Once it has anything in it,
+becomes a menu: "Choose Application…" first, then those clients by name. Picking one skips the app picker and asks only for the folder. Snapshot at open like the rest of the Settings model, in memory only, so it starts empty at each launch; the README and the section footer say so.AppListgains an optionaladdChoices; with none it is the plain button it was, so the ignored-apps list is untouched.Verified live (dev build)
+is the plain button, opens the app picker as before.+is a menu button (AXAXMenuButton) listingChoose Application…, separator,QuickTime Player.QuickTime Playeropens only the folder panel; choosing a folder writes{ "com.apple.QuickTimePlayerX": "~/Desktop/yap-route-test" }and the row appears with icon, name and folder.No change on the transcription or key-down path.
swift test: 52 passed.