Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Microsoft.NET.Test.Sdk package from version 17.14.0 to 18.0.1, addressing compatibility requirements for the newer SDK version by suppressing target framework support build errors in test projects.
- Bumped Microsoft.NET.Test.Sdk from v17.14.0 to v18.0.1
- Added SuppressTfmSupportBuildErrors property to prevent build errors related to target framework compatibility
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Directory.Packages.props | Updated Microsoft.NET.Test.Sdk package version to 18.0.1 |
| tests/Directory.Build.props | Added SuppressTfmSupportBuildErrors property to handle TFM compatibility issues with the new SDK version |
Files not reviewed (4)
- .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.agent.xml: Language not supported
- .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.ask.xml: Language not supported
- .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.ask2agent.xml: Language not supported
- .idea/.idea.System.IO.Abstractions/.idea/copilot.data.migration.edit.xml: Language not supported
Test Results 23 files - 8 23 suites - 8 8s ⏱️ -6s Results for commit 88e1795. ± Comparison against base commit 9caf7a1. This pull request removes 108 tests.This pull request skips 120 tests.♻️ This comment has been updated with latest results. |
auto-merge was automatically disabled
January 23, 2026 15:29
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Microsoft.NET.Test.Sdk package from version 17.14.0 to 18.0.1, addressing compatibility requirements for the newer SDK version by suppressing target framework support build errors in test projects.