Update to AwesomeAssertions/.NET9#202
Open
CaptaiNiveau wants to merge 7 commits intoTestably:mainfrom
Open
Conversation
added 7 commits
September 9, 2025 12:43
Author
|
Ah, I'll look into the style convention of the PR message as well as commit messages |
vbreuss
reviewed
Sep 10, 2025
Member
There was a problem hiding this comment.
I was an active contributor to Fluentassertions, but with their license changes abandoned the project (I am now using aweXpect instead).
So I also won't update this extension to Fluentassertions any longer. If you want, you can take it over and make it an extension for AwesomeAssertions, but maybe it would make more sense to move it there and rename it to e.g. AwesomeAssertions.Testably.Abstractions?
| <ItemGroup> | ||
| <PackageReference Include="AwesomeAssertions" /> | ||
| <PackageReference Include="Testably.Abstractions.Testing" /> | ||
| <PackageReference Remove="AwesomeAssertions" /> |
Member
There was a problem hiding this comment.
You should not need to add and remove AwesomeAssertions in the test project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I recently discovered your awesome testing libraries.
While trying the FluentAssertions nuget package, I couldn't compile them with Testably.Abstractions.
It seems to have a dependency on TestableIO.Abstractions, which break if said package isn't installed.
When I cloned the repo and added the project directly, everything worked as expected :)
However, instead of just asking for an update of the package, I tried updating/migrating it to the latest AwesomeAssertions version. I took the liberty to rename the project to AwesomeAssertions, since many other projects did the same.
Please take a look at my changes. The test suite ran successfully, though I'm not sure if my changes are to your standards (and if I did the migration to AssertionChain correctly).
Thank you for your effort!