Skip to content

fix: fixed removing current directory not throwing ioexception #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 10 commits into from
Feb 19, 2026
Merged

fix: fixed removing current directory not throwing ioexception #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d345a2
fix: fixed removing current directory not throwing ioexception
pw-sgr Feb 17, 2026
bc8304e
refactor: removed unnecessary path trimming
pw-sgr Feb 17, 2026
96de97a
test: moved tests from RemoveCurrentDirectoryTests and added parent d…
pw-sgr Feb 17, 2026
dedb687
test: fixed move test moving directory into itself
pw-sgr Feb 17, 2026
e28636b
test: fixed delete tests because delete wasn't recursive
pw-sgr Feb 17, 2026
f9507f4
fix: fixed handle checks in InMemoryStorage
pw-sgr Feb 18, 2026
7252de5
test: fixed test cases for current dir modification
pw-sgr Feb 18, 2026
b330185
test: applied suggestion of OnlyIf to current dir modification tests
pw-sgr Feb 18, 2026
7733583
fix: fixed handle check for modifiying directories similar to the cur…
pw-sgr Feb 19, 2026
173eb2e
fix: fixed trailing separator in file sharing exception
pw-sgr Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Source/Testably.Abstractions.Testing/Helpers/ExceptionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,22 @@ internal static FileNotFoundException FileNotFound(string path)
#endif
};

internal static IOException FileSharingViolation()
=> new("The process cannot access the file because it is being used by another process.")
{
#if FEATURE_EXCEPTION_HRESULT
HResult = -2147024864,
#endif
};

internal static IOException FileSharingViolation(string path)
=> new($"The process cannot access the file '{path}' because it is being used by another process.")
{
#if FEATURE_EXCEPTION_HRESULT
HResult = -2147024864,
#endif
};

internal static ArgumentException HandleIsInvalid(string? paramName = "handle")
=> new("Invalid handle.", paramName);

Expand Down Expand Up @@ -297,6 +313,14 @@ internal static UnauthorizedAccessException AccessDenied(string path)
#endif
};

internal static IOException IOAccessDenied(string path)
=> new($"Access to the path '{path}' is denied.")
{
#if FEATURE_EXCEPTION_HRESULT
HResult = -2147024891,
#endif
};

internal static PlatformNotSupportedException UnixFileModeNotSupportedOnThisPlatform()
=> new("Unix file modes are not supported on this platform.")
{
Expand Down
53 changes: 52 additions & 1 deletion Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ public bool DeleteContainer(
}

ValidateContainerType(container.Type, expectedType, _fileSystem.Execute, location);


ValidateDeleteHandle(container, location.FullPath);

if (container.Type == FileSystemTypes.Directory)
{
IEnumerable<IStorageLocation> children =
Expand Down Expand Up @@ -992,6 +994,8 @@ private bool IncludeItemInEnumeration(
return null;
}

ValidateMoveHandle(container, source.FullPath);

if (container.Type == FileSystemTypes.Directory &&
source.FullPath.Equals(destination.FullPath, _fileSystem.Execute.IsNetFramework
? StringComparison.OrdinalIgnoreCase
Expand Down Expand Up @@ -1197,6 +1201,53 @@ private static void ValidateContainerType(
}
}

private void ValidateDeleteHandle(IStorageContainer container, string fullPath)
{
if (!_fileSystem.Execute.IsWindows || container.Type != FileSystemTypes.Directory)
{
return;
}

string? currentDirectory
= _fileSystem.Directory.GetCurrentDirectory().NormalizePath(_fileSystem);

string currentDirectoryWithSeparator
= currentDirectory + _fileSystem.Path.DirectorySeparatorChar;

string fullPathWithSeparator = fullPath + _fileSystem.Path.DirectorySeparatorChar;

if (currentDirectoryWithSeparator.StartsWith(
fullPathWithSeparator, _fileSystem.Execute.StringComparisonMode
))
{
throw ExceptionFactory.FileSharingViolation(currentDirectory);
}
}

private void ValidateMoveHandle(IStorageContainer container, string fullPath)
{
if (!_fileSystem.Execute.IsWindows || container.Type != FileSystemTypes.Directory)
{
return;
}

string? currentDirectory
= _fileSystem.Directory.GetCurrentDirectory().NormalizePath(_fileSystem)
+ _fileSystem.Path.DirectorySeparatorChar;

string fullPathWithSeparator = fullPath + _fileSystem.Path.DirectorySeparatorChar;

if (currentDirectory.Equals(fullPathWithSeparator, _fileSystem.Execute.StringComparisonMode))
{
throw ExceptionFactory.FileSharingViolation();
}

if (currentDirectory.StartsWith(fullPathWithSeparator, _fileSystem.Execute.StringComparisonMode))
{
throw ExceptionFactory.IOAccessDenied(fullPath);
}
}

private static void ValidateExpression(string expression)
{
if (expression.Contains('\0', StringComparison.Ordinal))
Expand Down
67 changes: 67 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/Directory/DeleteTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,4 +306,71 @@ await That(Act).Throws<IOException>()
: $"'{FileSystem.Path.Combine(BasePath, path)}'");
await That(FileSystem.Directory.Exists(path)).IsTrue();
}

[Theory]
[AutoData]
[InlineData(null)]
public async Task Delete_CurrentDirectory_ShouldThrowIOException_OnWindows(string? nested)
{
// Arrange
string directory = FileSystem.Directory.GetCurrentDirectory();
string expectedExceptionDirectory = directory;

if (nested != null)
{
string nestedDirectory = FileSystem.Path.Combine(directory, nested);
FileSystem.Directory.CreateDirectory(nestedDirectory);
FileSystem.Directory.SetCurrentDirectory(nestedDirectory);
expectedExceptionDirectory = nestedDirectory;
}

// Act
void Act()
{
FileSystem.Directory.Delete(directory, true);
}

try
{
// Assert
await That(Act).ThrowsExactly<IOException>().OnlyIf(Test.RunsOnWindows).Which
.HasMessage(
$"The process cannot access the file '*{expectedExceptionDirectory}' because it is being used by another process."
).AsWildcard();
}
finally
{
if (Test.RunsOnWindows)
{
// Cleanup
FileSystem.Directory.SetCurrentDirectory(BasePath);
}
}
}

[Theory]
[InlineData("next")]
[InlineData("next", "sub")]
public async Task Delete_DirNextToCurrentDirectory_ShouldNotThrow(params string[] paths)
{
// Arrange
string directory = FileSystem.Directory.GetCurrentDirectory();
// Intended missing separator, we want to test that the handle does not affect similar paths
string nextTo = directory + FileSystem.Path.Combine(paths);

FileSystem.Directory.CreateDirectory(nextTo);
FileSystem.Directory.SetCurrentDirectory(nextTo);

// Act
void Act()
{
FileSystem.Directory.Delete(directory, true);
}

// Assert
await That(Act).DoesNotThrow();

await That(FileSystem.Directory.Exists(directory)).IsFalse();
await That(FileSystem.Directory.Exists(nextTo)).IsTrue();
}
}
80 changes: 80 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/Directory/MoveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,4 +268,84 @@ await That(
SearchOption.AllDirectories))
.HasSingle();
}

[Fact]
public async Task Move_CurrentDirectory_ShouldThrowIOException_OnWindows()
{
// Arrange
string directory = FileSystem.Directory.GetCurrentDirectory();
string newPath = FileSystem.Path.GetFullPath("../new");

// Act
void Act()
{
FileSystem.Directory.Move(directory, newPath);
}

// Assert
await That(Act).ThrowsExactly<IOException>().OnlyIf(Test.RunsOnWindows).Which.HasMessage(
"The process cannot access the file because it is being used by another process."
);
}

[Theory]
[AutoData]
public async Task Move_NestedCurrentDirectory_ShouldThrowIOException_OnWindows(string nested)
{
// Arrange
string directory = FileSystem.Directory.GetCurrentDirectory();
string newPath = FileSystem.Path.GetFullPath("../new");

string nestedDirectory = FileSystem.Path.Combine(directory, nested);
FileSystem.Directory.CreateDirectory(nestedDirectory);
FileSystem.Directory.SetCurrentDirectory(nestedDirectory);

// Act
void Act()
{
FileSystem.Directory.Move(directory, newPath);
}

// Assert
try
{
await That(Act).ThrowsExactly<IOException>().OnlyIf(Test.RunsOnWindows).Which
.HasMessage($"Access to the path '{directory}' is denied.");
}
finally
{
if (Test.RunsOnWindows)
{
// Cleanup
FileSystem.Directory.SetCurrentDirectory(BasePath);
}
}
}

[Theory]
[InlineData("next")]
[InlineData("next", "sub")]
public async Task Move_DirNextToCurrentDirectory_ShouldNotThrow(params string[] paths)
{
// Arrange
string directory = FileSystem.Directory.GetCurrentDirectory();
// Intended missing separator, we want to test that the handle does not affect similar paths
string nextTo = directory + FileSystem.Path.Combine(paths);
string moveTarget = FileSystem.Path.Combine(nextTo, "move-target");

FileSystem.Directory.CreateDirectory(nextTo);
FileSystem.Directory.SetCurrentDirectory(nextTo);

// Act
void Act()
{
FileSystem.Directory.Move(directory, moveTarget);
}

// Assert
await That(Act).DoesNotThrow();

await That(FileSystem.Directory.Exists(directory)).IsFalse();
await That(FileSystem.Directory.Exists(nextTo)).IsTrue();
}
}
67 changes: 67 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/DeleteTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,71 @@ await That(Act).Throws<IOException>()
await That(sut.Exists).IsTrue();
await That(FileSystem.Directory.Exists(sut.FullName)).IsTrue();
}

[Theory]
[AutoData]
[InlineData(null)]
public async Task Delete_CurrentDirectory_ShouldThrowIOException_OnWindows(string? nested)
{
// Arrange
string directory = FileSystem.Directory.GetCurrentDirectory();
string expectedExceptionDirectory = directory;

if (nested != null)
{
string nestedDirectory = FileSystem.Path.Combine(directory, nested);
FileSystem.Directory.CreateDirectory(nestedDirectory);
FileSystem.Directory.SetCurrentDirectory(nestedDirectory);
expectedExceptionDirectory = nestedDirectory;
}

// Act
void Act()
{
FileSystem.DirectoryInfo.New(directory).Delete(true);
}

try
{
// Assert
await That(Act).ThrowsExactly<IOException>().OnlyIf(Test.RunsOnWindows).Which
.HasMessage(
$"The process cannot access the file '*{expectedExceptionDirectory}' because it is being used by another process."
).AsWildcard();
}
finally
{
if (Test.RunsOnWindows)
{
// Cleanup
FileSystem.Directory.SetCurrentDirectory(BasePath);
}
}
}

[Theory]
[InlineData("next")]
[InlineData("next", "sub")]
public async Task Delete_DirNextToCurrentDirectory_ShouldNotThrow(params string[] paths)
{
// Arrange
string directory = FileSystem.Directory.GetCurrentDirectory();
// Intended missing separator, we want to test that the handle does not affect similar paths
string nextTo = directory + FileSystem.Path.Combine(paths);

FileSystem.Directory.CreateDirectory(nextTo);
FileSystem.Directory.SetCurrentDirectory(nextTo);

// Act
void Act()
{
FileSystem.DirectoryInfo.New(directory).Delete(true);
}

// Assert
await That(Act).DoesNotThrow();

await That(FileSystem.Directory.Exists(directory)).IsFalse();
await That(FileSystem.Directory.Exists(nextTo)).IsTrue();
}
}
Loading
Loading