Skip to content

Am263x: PRU-I2S #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajul-bhambay wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Am263x: PRU-I2S #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9175ef
Am263x/AM261x: PRU-I2S
rajul-bhambay Apr 17, 2025
2dd5549
Am263x/AM261x: PRU-I2S
rajul-bhambay Apr 29, 2026
ca2034c
Am263x/AM261x: PRU-I2S
rajul-bhambay Apr 29, 2026
b92802e
Am263x/AM261x: PRU-I2S
rajul-bhambay May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .metadata/product.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
"documentationPath": "../docs",
Copy link
Copy Markdown
Collaborator

@dhavaljk dhavaljk Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commits. There are two signed-off lines. Also, squash commits as commit message is same

"includePaths": [
"../source",
Copy link
Copy Markdown
Collaborator

@dhavaljk dhavaljk Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any changes in this file? If not, please revert

"C:/ti/mcu_plus_sdk/source/sysconfig",
],
"components": [

"/open_pru",
],
Comment on lines 6 to 12
Copy link
Copy Markdown

@qodo-code-review qodo-code-review Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

6. Hardcoded sdk include path 🐞 Bug ☼ Reliability

.metadata/product.json adds a Windows-specific absolute include path (C:/ti/...), which will break
builds on non-Windows hosts and in CI environments where that path does not exist. This is a
portability/build blocker for the repo.
Agent Prompt 
### Issue description
A Windows-only absolute include path was added to `.metadata/product.json`, breaking portability and CI.

### Issue Context
`includePaths` contains `C:/ti/mcu_plus_sdk/source/sysconfig`.

### Fix Focus Areas
- .metadata/product.json[5-12]

### What to change
- Remove the absolute path.
- Replace with a repo-relative path (if the headers are in-repo), or use a variable-based mechanism supported by the build system (e.g., environment variable or a path relative to an SDK import root already defined in `imports.mak`).
- Ensure includePaths remains valid on Linux/macOS and Windows without local customization.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

"devices": [
"AM64x",
Comment on lines 5 to 14
Copy link
Copy Markdown

@qodo-code-review qodo-code-review Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

5. Invalid json trailing commas 🐞 Bug ≡ Correctness

.metadata/product.json contains trailing commas in arrays (e.g., includePaths/devices/components),
which makes the file invalid strict JSON and can break any tooling that parses it as JSON. The PR
adds an includePaths entry that retains this invalid trailing comma pattern.
Agent Prompt 
### Issue description
`.metadata/product.json` is not valid strict JSON due to trailing commas in arrays.

### Issue Context
Many JSON parsers used by build/config tooling reject trailing commas.

### Fix Focus Areas
- .metadata/product.json[5-21]

### Suggested change
- Remove trailing commas after the last element in `includePaths`, `components`, `devices` (and anywhere else in the file).
- If the consuming tooling expects JSON5, consider renaming to `.json5` and documenting it; otherwise keep strict JSON compliance.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Expand Down
2 changes: 1 addition & 1 deletion examples/makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ include ../imports.mak
SUBDIRS := \
custom_frequency_generator empty empty_c \
fft/split_radix_fft_4k_single_core fft/split_radix_fft_post_processing \
LCD_interface logic_scope pru_emif spi_loopback \
LCD_interface logic_scope pru_emif pru_i2s spi_loopback \
fir multicore_scheduler rpmsg_echo_linux

# "make" or "make all" builds projects that match $(DEVICE) set in imports.mak
Expand Down
Loading
Loading