fix readline support#4133
Closed
florentx wants to merge 1 commit into
Closed
Conversation
Author
|
@willmcgugan it is a bit harsh to get a close notification without a comment. Is there any policy violation? I did not find, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, I had the issue when using
Prompt.ask(...),Confirm.ask(...)orConsole.input(...).I import builtin
readlineto get line editing capability.When navigating the line to the left with the arrow key, cursor goes to the start of the line and overwrite the prompt text.
This can be fixed, if the
inputbuilt-in function receives the prompt text.Also I've added a convenient helper (static method) to enable
readline.