Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I created seperate repo that uses latest xterm.js version and also includes some useful xterm addons like for instance sixel image support.
Repo - https://github.com/uriyyo/textual-xterm
Happy to transfer repo to textualize github org if you consider this PR and implementation as smth useful for textual.
Main motivation behind this PR is to support image rendering with
textual serveit required to create new env varsTEXTUAL_CELL_WIDTHandTEXTUAL_CELL_HEIGHTso libraries liketextual-imagecan addapt and use correct pixel size when rendering images.Demo how it look like in browser:
