Skip to content

Fix Alt modifier on named keys - #6674

Open
happykawayigt wants to merge 1 commit into
Textualize:mainfrom
happykawayigt:fix/alt-named-key-modifier
Open

Fix Alt modifier on named keys#6674
happykawayigt wants to merge 1 commit into
Textualize:mainfrom
happykawayigt:fix/alt-named-key-modifier

Conversation

@happykawayigt

Copy link
Copy Markdown

Fixes #6663

Summary

  • preserve the Alt prefix for named keys parsed from ESC-prefixed terminal input
  • keep uppercase shift normalization scoped to single-character keys
  • add regression coverage for alt+enter and alt+question_mark

Testing

  • .venv\Scripts\python.exe -m pytest -q tests\test_xterm_parser.py (68 passed, 1 xfailed)
  • .venv\Scripts\python.exe -m black --check src\textual\_xterm_parser.py tests\test_xterm_parser.py
  • direct parser reproduction now yields ["alt+enter"]
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alt modifier dropped on named keys (Alt+Enter arrives as plain enter)

1 participant