Fix SelectCurrent.update() crash when called before mount (#6581) - #6680
Open
rudrakumar07 wants to merge 1 commit into
Open
Fix SelectCurrent.update() crash when called before mount (#6581)#6680rudrakumar07 wants to merge 1 commit into
rudrakumar07 wants to merge 1 commit into
Conversation
Guard the query_one("#label") call in SelectCurrent.update() with
an is_mounted check. When update() is called before the widget is
mounted (e.g., from _watch_value during initialization), the #label
child doesn't exist yet, causing a NoMatches crash.
Fixes Textualize#6581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6581.
SelectCurrent.update()queried#labelbefore the widget was mounted, causing a crash. Addedif self.is_mounted:guard around thequery_onecall, matching the existing pattern in_watch_prompt.