Fix markup.escape regex to handle nested brackets (#6614) - #6681
Open
rudrakumar07 wants to merge 2 commits into
Open
Fix markup.escape regex to handle nested brackets (#6614)#6681rudrakumar07 wants to merge 2 commits into
rudrakumar07 wants to merge 2 commits into
Conversation
added 2 commits
August 2, 2026 20:13
Guard the query_one("#label") call in SelectCurrent.update() with
an is_mounted check. When update() is called before the widget is
mounted (e.g., from _watch_value during initialization), the #label
child doesn't exist yet, causing a NoMatches crash.
Fixes Textualize#6581
The escape function's regex r"(\\*)(\[[a-z#/@][^[]*?])" used [^[]*? which stops at nested opening brackets, causing strings like "[a [b] c]" (Pydantic-style) to fail. The old regex would only match the inner [b] instead of the whole tag. Update the regex to allow one level of nested brackets using (?:[^[]]*(?:\[[^\]]*\])?[^\]]*)* which matches non-bracket characters optionally followed by a nested bracket pair. Fixes Textualize#6614
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6614.
The escape regex
[^[]*?stopped at nested[characters, causing strings like[a [b] c]to only match the inner[b]. Updated regex to handle one level of nested brackets.