Fix textarea undo crash - #6687
Open
guillaumelgf wants to merge 1 commit into
Open
Conversation
guillaumelgf
marked this pull request as ready for review
August 6, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #6686
Summary
Fixes a
TextAreaundo crash that can happen after undoing a large multiline paste.During undo, the document may already be restored to its shorter previous state while the cursor location still temporarily points into the pasted text. If scrollbar refresh tries to scroll that stale cursor location into view,
WrappedDocument.location_to_offset()canraise because the row no longer exists.
This change clamps the cursor location used for the visual offset calculation, without mutating the actual selection. The undo flow can then finish restoring the selection normally.