Update text layout cache checking #trivial#930
Open
Adlai-Holler wants to merge 1 commit intomasterfrom
Open
Conversation
Generated by 🚫 Danger |
Adlai-Holler
changed the title
|
Adlai Holler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
@Adlai-Holler, looks like this could use a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug in #553 .
The solution in that diff was actually landed incidentally in #918 which fixes the correctness of the check, but degrades layout performance and memory by recomputing layouts more often.
This diff changes the check to have both the correctness fix and improved performance. I tested the diff against the sample code that @wsdwsd0829 gave and it fixes that case.
It also modifies ASTextLayout to use pixel-ceiling rather than point-ceiling.