Merged
Conversation
Added checks to ensure sizes fit into int before casting.
Thalhammer
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks to ensure sizes fit into int before casting.
I made these changes to solve AppVeyor warnings from Building Domoticz.
The third parameter (len) is expected to be of type int in OpenSSL's function signature:
int BIO_write(BIO *b, const void *data, int dlen);The Last Warning is from commit "71c3d36"
if (get_type() == json::type::number) return system_clock::from_time_t(std::round(as_number()));But this is changed in the last master to;
if (get_type() == json::type::number) return date(std::chrono::seconds(std::llround(as_number())));so this is probably already solved.
Kind Regards