Skip to content

Fix flaky CI tests#36

Merged
poxet merged 1 commit intomasterfrom
develop
Apr 6, 2026
Merged

Fix flaky CI tests#36
poxet merged 1 commit intomasterfrom
develop

Conversation

@poxet
Copy link
Copy Markdown
Contributor

@poxet poxet commented Apr 6, 2026

Summary

  • TimeToIdleCacheTests / TimeToLiveCacheTests — increased TTL from 200ms to 400ms and delays from 100ms to 200/250ms for CI runner tolerance
  • InvalidateTests — added 200ms delay to fetch delegate to prevent background refresh racing with assertions in staleWhileRevalidate mode
  • FetchDataThrottleTests — increased maxTime margin from +200 to +400

Test plan

  • CI build passes with no flaky test failures

TimeToIdleCacheTests and TimeToLiveCacheTests: increased TTL from 200ms
to 400ms and delays from 100ms to 200/250ms for CI runner tolerance.
InvalidateTests: added 200ms delay to fetch delegate to prevent
background refresh racing with assertions in staleWhileRevalidate mode.
FetchDataThrottleTests: increased maxTime margin from +200 to +400.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Tharga.Cache.Tests/TimeToIdleCacheTests.cs 0.00% 7 Missing ⚠️
Tharga.Cache.Tests/TimeToLiveCacheTests.cs 0.00% 7 Missing ⚠️
Tharga.Cache.Tests/InvalidateTests.cs 0.00% 4 Missing ⚠️
Tharga.Cache.Tests/FetchDataThrottleTests.cs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@poxet poxet merged commit 319fae5 into master Apr 6, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant