Conversation
Restores the test filter from the legacy Azure DevOps pipeline: '(Category!=Integration)&(Category!=TimeCritical)'. - Integration tests need a live Mongo/Redis instance. - TimeCritical tests in FetchDataThrottleTests assert wall-clock parallelism timing (e.g. 'elapsed < 200ms'). They're meaningful when run on a quiet local machine to validate FetchQueue throttling, but flake on shared GitHub-hosted runners with no consistent capacity. Both categories stay runnable locally without the filter.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous merge to master (PR #39) failed its post-merge CI run on two known wall-clock-flaky tests:
FetchDataThrottleTests.ManyParallelCallsAreQueuedandManyParallelCallsAreQueuedForDifferentTypes. Both are decorated with[Trait(\"Category\", \"TimeCritical\")]and were filtered out of the legacy Azure DevOps pipeline, but the new GitHub Actions workflow runs everything.This PR restores the legacy test filter on the workflow's
Test with coveragestep:FetchQueuethrottling tests assert wall-clock parallelism timing (e.g. "elapsed < 200ms"). Useful when run on a quiet developer machine; unreliable on shared GitHub-hosted runners.Both categories remain runnable locally (no filter applied for
dotnet testinvocations from a developer shell).Test plan