fix(deps): pin Microsoft.AspNetCore.DataProtection >= 10.0.7 for net10.0#56
Merged
Conversation
Adds an explicit PackageReference for Microsoft.AspNetCore.DataProtection in the net10.0 conditional ItemGroup. Today the package only flows in transitively (via Microsoft.Identity.Web / the shared framework). Pinning declares a known-good floor in the Tharga.Team.Blazor .nuspec so consumer apps get a >= 10.0.7 dependency declaration. Suppress NU1510 in this csproj — the package is part of the shared framework, so the .NET 10 SDK would otherwise warn that the local build prunes the reference. The pin is for downstream consumer metadata, not for the build of this assembly itself. net9.0 left unpinned (request specified 10.0.7 only). Can be added in a follow-up if a 9.x floor is also needed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit
PackageReferenceforMicrosoft.AspNetCore.DataProtection10.0.7 in thenet10.0conditionalItemGroupofTharga.Team.Blazor.csproj.Today the package flows in only transitively (via
Microsoft.Identity.Web/ the shared framework). The explicit reference declares a known-good>= 10.0.7floor in the consumer-facing.nuspec, so apps that consumeTharga.Team.Blazorget the dependency declaration even if the rest of their graph would resolve a lower version.Notes
Microsoft.AspNetCore.Appshared framework, so the SDK warns the local build prunes the explicit reference. The pin is for downstream consumer metadata, not for the build of this assembly itself.>= 10.0.7only. A 9.x floor can be added in a follow-up if needed.Tests
255 tests pass, 0 warnings.
Test plan
Tharga.Team.Blazor.nupkglistsMicrosoft.AspNetCore.DataProtection >= 10.0.7under net10.0 dependencies