Skip to content

Develop#38

Merged
poxet merged 4 commits into
masterfrom
develop
Apr 28, 2026
Merged

Develop#38
poxet merged 4 commits into
masterfrom
develop

Conversation

@poxet
Copy link
Copy Markdown
Contributor

@poxet poxet commented Apr 28, 2026

Summary

  • ci: add GitHub Actions workflow (build.yml) for build, test, and NuGet publish
  • Based on Tharga.Mcp's reference workflow (post prerelease-version-fix)
  • MAJOR_MINOR: '1.15' — first auto-version will be 1.15.0
  • Packs both Tharga.Toolkit and Tharga.Toolkit.Standard
  • CI on PRs (build, test, Codecov, CodeQL, pre-release pack)
  • CD on push to master (stable NuGet publish + GitHub Release via release environment)
  • Pre-release on PR via prerelease environment (manual approval)

Test plan

  • YAML syntax valid (file written cleanly)
  • First merge to master triggers stable build → publishes 1.15.0 to NuGet
  • PR builds publish pre-release 1.15.0-pre.N (gated by prerelease environment approval)
  • CodeQL analysis runs on every build
  • Codecov receives coverage upload (token already configured)

Notes

  • This effectively replaces any prior Azure DevOps pipeline (per backlog: 03-github-actions-ci)
  • Pending-migration list in plans/Mcp/done/prerelease-version-fix.md should now drop "Toolkit" from its set

- Build/test on PRs to master (net8.0, net9.0, net10.0)
- Codecov coverage upload, CodeQL security scan
- Pack both Tharga.Toolkit and Tharga.Toolkit.Standard
- Stable release on push to master (NuGet + GitHub Release)
- Pre-release on PR via prerelease environment (manual approval)
- MAJOR_MINOR=1.15, patch auto-incremented from git tags

Based on Tharga.Mcp's workflow (post prerelease-version-fix).
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

poxet added 3 commits April 28, 2026 23:58
- HashString.Value now uses the new keyword to explicitly hide
  Hash.Value (CS0108)
- Suppress xUnit1051 in test projects (TestContext.Current.CancellationToken
  guidance is test-only style; not blocking CI)

Build now produces 0 warnings (was 38+, exceeding the CI threshold of 15).
Tharga.Test.Toolkit's GetStandardAssembliesToIgnore() doesn't include
System.Runtime when running on Linux/.NET 10 (it does locally on
Windows). Following the existing pattern of manually appending
"mscorlib", add "System.Runtime" to the allowlist.
The .NET 10 runtime surfaces different framework assemblies
(System.Runtime, System.Threading, ...) as transitive references
depending on environment. Filter the entire System.* namespace
rather than listing each one individually.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@poxet poxet merged commit 309619e into master Apr 28, 2026
5 of 6 checks passed
@github-actions
Copy link
Copy Markdown

Released as v1.15.23https://github.com/Tharga/Toolkit/releases/tag/1.15.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants