Skip to content

Update urllib3 to 2.6.0 due to CVE-2025-66418#4260

Open
maliberty wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:at-update-urllib3
Open

Update urllib3 to 2.6.0 due to CVE-2025-66418#4260
maliberty wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:at-update-urllib3

Conversation

@maliberty
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this May 27, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the urllib3 dependency version in tools/AutoTuner/requirements.txt from >=1.26.17 to >=2.6.0. However, the specified version 2.6.0 does not exist on PyPI, which will cause pip install to fail. It is recommended to use a valid, existing version such as >=2.3.0 instead.

protobuf>=5.26.1
SQLAlchemy==1.4.17
urllib3>=1.26.17
urllib3>=2.6.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version 2.6.0 for urllib3 does not exist on PyPI (the latest version is 2.3.0). Specifying urllib3>=2.6.0 will cause pip install to fail because the package manager cannot find a matching version. Please use a valid, existing version of urllib3 (such as 2.3.0).

urllib3>=2.3.0

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, there is a version 2.7.0 at https://pypi.org/project/urllib3/#history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant