mpl: rename default halo to base halo on new command for clarity#10159
mpl: rename default halo to base halo on new command for clarity#10159AcKoucher wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the set_macro_default_halo command and its associated internal variables to set_macro_base_halo across the codebase, including documentation, C++ classes, and Tcl scripts. The review feedback highlights an opportunity to update a report label for consistency, suggests improving the formatting of a warning message to avoid excessive whitespace, and recommends maintaining backward compatibility by providing a deprecated alias for the removed command.
|
clang-tidy review says "All clean, LGTM! 👍" |
3 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
AcKoucher
force-pushed
the
mpl-set-base-macro-halo
branch
from
80d17e1 to
46d1e1d
Compare
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
AcKoucher
force-pushed
the
mpl-set-base-macro-halo
branch
from
46d1e1d to
4460539
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
It would be good to make a forwarding proc from the old name to the new one with a deprecated warning. |
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@maliberty Done. |
2 participants
Summary
In MPL, we always floor the DEF halo to the default halo dimensions, so that makes it more of a base halo than a default halo per say.
Type of Change
Impact
No impact.
Verification
./etc/Build.sh).