ram: bloat occupied layers in abstract lef tests#10169
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Apr 18, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the RAM generation tests for Nangate45 and Sky130 by adding the -bloat_occupied_layers flag to the write_abstract_lef command. Consequently, the reference .lefok files have been updated to reflect simplified obstruction (OBS) layers, replacing numerous small rectangles with single bounding boxes for each metal layer. I have no feedback to provide.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome to OpenROAD! Thanks for opening your first PR.
Before we review:
- Contribution Guide: https://openroad.readthedocs.io/en/latest/contrib/contributing.html
- Build Instructions: https://openroad.readthedocs.io/en/latest/contrib/BuildWithCMake.html
Please ensure:
- CI passes
- Code is properly formatted
- Tests are included where applicable
A maintainer will review shortly!
rovinski
approved these changes
Apr 17, 2026
Collaborator
|
@tarunWebBuilder thank you for the contribution, please read the test details to fix the DCO. Please also investigate why the CI is failing on the change. |
Signed-off-by: Tarun <tarunpahade55@gmail.com>
tarunWebBuilder
force-pushed
the
ram-bloat-occupied-layers-tests
branch
from
952c476 to
63aa86f
Compare
maliberty
approved these changes
Apr 18, 2026
maliberty
merged commit a00a575
into
The-OpenROAD-Project:master
15 of 16 checks passed
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update RAM abstract LEF tests to call
write_abstract_lef -bloat_occupied_layers.This changes the RAM LEF golden files to expect whole-layer obstructions instead of detailed obstruction geometry.
Type of Change
Impact
RAM test LEFs now use simplified cover obstructions for occupied layers. This reduces LEF complexity for generated RAM abstracts while keeping the existing RAM generation flow unchanged.
Verification
./etc/Build.sh).Local tests were not run because this Windows checkout does not have
tclshor a built OpenROAD executable available.Related Issues
Fixes #10154