cmake: unset BUILD_GUI when Qt5 is not found#10171
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Apr 17, 2026
Merged
Conversation
When BUILD_GUI is ON but Qt5 is not found, the build silently falls back to a stub library. However, the top-level CMakeLists.txt still sets the BUILD_GUI=1 compile definition based on the option alone, causing openroad_gui_compiled to return true at runtime even though gui::show was never registered. This leads to "invalid command name gui::show" errors in batch mode. Fix by unsetting BUILD_GUI in the cache when Qt5 is not found, so the compile definition correctly reflects the actual build state. Resolves The-OpenROAD-Project/OpenROAD-flow-scripts#4134 Signed-off-by: alokkumardalei-wq <alokkumardalei2@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CMake configuration in src/gui/CMakeLists.txt to explicitly set the BUILD_GUI cache variable to OFF when QT5 is not found. This ensures that the build system state is correctly synchronized with the available dependencies. I have no feedback to provide.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
Hello @maliberty , all checks are passing, please have a look onto this when you get time. Thank you ! |
maliberty
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When BUILD_GUI is ON but Qt5 is not found, the build silently falls back to a stub library. However, the top-level CMakeLists.txt still sets the BUILD_GUI=1 compile definition based on the option alone, causing openroad_gui_compiled to return true at runtime even though gui::show was never registered. This leads to "invalid command name gui::show" errors in batch mode.
Fix by unsetting BUILD_GUI in the cache when Qt5 is not found, so the compile definition correctly reflects the actual build state.
Resolves The-OpenROAD-Project/OpenROAD-flow-scripts#4134
Type of Change
Verification
./etc/Build.sh).