drt: suppress DRT-0349 warning on PDKs without CUTCLASS support#10174
Open
dnltz wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Open
drt: suppress DRT-0349 warning on PDKs without CUTCLASS support#10174dnltz wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
dnltz wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
LEF58_ENCLOSURE rules without a CUTCLASS are skipped regardless, but the warning was firing unconditionally. On PDKs that define no cut classes at all, the warning is expected and not actionable. Guard it so it only fires when the layer actually has cut class rules defined. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
Contributor
Author
|
Let me know if I should provide a test to trigger |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the io::Parser::setCutLayerProperties function in src/drt/src/io/io.cpp to suppress the DRT-0349 warning regarding unsupported LEF58_ENCLOSURE without a CUTCLASS when no cut class rules are defined for the layer. Multiple test expectation files have been updated to reflect the removal of these warnings from the output. I have no feedback to provide as there were no review comments to evaluate.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
DRT-0349 is now suppressed when LEF58_ENCLOSURE and CUTCLASS are not defined in a layer. Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
dnltz
force-pushed
the
WIP/dnltz/suppress-drt-0349
branch
from
6862a20 to
3958ac0
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LEF58_ENCLOSURE rules without a CUTCLASS are skipped regardless, but the warning was firing unconditionally. On PDKs that define no cut classes at all, the warning is expected and not actionable. Guard it so it only fires when the layer actually has cut class rules defined.
Type of Change
Impact
No
Verification
./etc/Build.sh).