Skip to content

Add new Tcl and C++ test cases#294

Merged
maliberty merged 65 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-sta-test-by-opus
Apr 2, 2026
Merged

Add new Tcl and C++ test cases#294
maliberty merged 65 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-sta-test-by-opus

Conversation

@openroad-ci
Copy link
Copy Markdown
Collaborator

@openroad-ci openroad-ci commented Feb 24, 2026

Summary

  • Adds comprehensive C++ and Tcl regression test suites across all 12 STA modules — 6,159 tests, 100% pass rate
  • Strengthens all C++ assertions with meaningful checks, removes empty test bodies
  • Adapts all tests to the upstream rel_3.0 API (Corner → Scene/Mode, enum class changes, command renames, etc.)

Test Coverage by Module

Module C++ Tests Tcl Tests Total
search 1,788 74 1,862
liberty 1,005 38 1,043
sdc 870 40 910
network 577 26 603
dcalc 383 — 383
util 317 9 326
verilog 278 41 319
parasitics 199 17 216
spice 126 9 135
sdf 115 10 125
graph 100 11 111
power 96 8 104
test — 22 22
Total 5,854 305 6,159
image

C++ Tests (GTest)

  • Covers delay calculation, graph construction, liberty parsing, network traversal, parasitics reduction, power analysis, SDC constraints, timing search, utility functions, and Verilog I/O
  • Each module has dedicated test fixtures with realistic design data (liberty, Verilog, SPEF, SDC)

Tcl Tests

  • Integration-level tests exercising the full STA flow through Tcl commands
  • Each test includes a .ok golden reference file for output verification

Note: Upstream Merge

This branch includes the upstream STA rel_3.0 merge (PR #288), which introduces the Scene/Mode architecture replacing Corner, enum class migrations, warning format changes, and Tcl command renames. All tests have been adapted to these API changes.

Test plan

  • All 6,159 regression tests pass (ctest -j64)
  • C++ tests: 5,854 pass
  • Tcl tests: 305 pass

🤖 Generated with Claude Code

jhkim-pii and others added 27 commits February 13, 2026 19:19
@jhkim-pii
test: Initial upload
d6c0937 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
test: Refactoring. Standardize Google Test naming conventions by remo…
b77779f 
…ving `R#_` prefixes, improve temporary file creation with `mkstemp`, etc

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
sdc: Fix dangling pointer issue in Sdc::deleteDeratingFactors()
c147d63 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
test: Remove redundant results folder
fdb24d8 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
test: Apply review feedback - part1
6799b19 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
test: Apply review feedback - part2
547737f 
- Remove stale line-number coverage comments (# Targets: line NNN, hit=0)
- Remove useless file-existence checks from verilog/sdf tests
- Delete 21 orphaned dcalc Tcl tests (C++ tests already cover them)
- Rename liberty_ccsn_ecsm -> liberty_ccsn (no ECSM libs available)
- Fix liberty_sky130_corners to use define_corners/-corner for real multi-corner testing
- Add report_checks per wireload model in liberty_wireload
- Fix test/regression to work from test/ directory (label mismatch)
- Refactor all module CMakeLists.txt with sta_module_tests() macro

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Apply review feedback - part3
e57c804 
Remove unnecessary catch blocks from Tcl test files across all modules,
add report_checks after each set_wire_load_model in liberty_wireload,
rewrite liberty_sky130_corners for actual multi-corner timing analysis
with define_corners, and expand C++ tests (TestSearchIncremental 8→36,
TestPower 71→96, TestSpice 98→126 tests).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Apply review feedback - part3
5c9b4d7 
Remove unnecessary catch blocks across all test modules (graph,
liberty, network, parasitics, power, sdc, sdf, search, spice,
verilog), expand C++ tests (TestSearchIncremental 8→36 tests,
TestPower 71→96, TestSpice 98→126), add report_checks after each
set_wire_load_model in liberty_wireload.tcl, and rewrite
liberty_sky130_corners.tcl with actual multi-corner timing analysis.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Apply review feedback - part4
812d26f 
Remove unnecessary catch blocks in network, parasitics, sdc, spice,
and util test modules. Add report_checks after set_wire_load_model
in parasitics_wireload.tcl to verify timing changes per wireload.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Fix wrong API calls in Tcl tests and remove unnecessary catches
ce45133 
Replace wrong/non-existent command calls with correct OpenSTA APIs:
- sta::pin_slack → get_property $pin slack_max_rise
- sta::slow_drivers_cmd → sta::slow_drivers
- set_latch_borrow_limit → set_max_time_borrow
- remove_data_check → unset_data_check
- remove_clock → delete_clock
- reset_path → unset_path_exceptions
- sta::report_path_end 3-arg → sta::report_path_end2
- sta::design_power "NULL" → sta::design_power [sta::cmd_corner]
- report_path $path → sta::report_path_cmd $path
- connect_pin 3-arg → connect_pin net inst/port
- set_power_activity positional → -input_ports flag
- sta::is_clock [get_ports] → sta::is_clock [sta::get_port_pin]
- get_property $inst lib_name → liberty_cell/liberty_library
- get_property $pin net_name → [$pin net] + get_full_name
- get_property $net is_power → $net is_power method
- Removed unnecessary catch around sta::write_liberty

23 catch blocks removed. Tests now execute real API calls instead
of silently failing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Add explanatory comments to all catch blocks in Tcl tests
726a64a 
Document why each catch block is needed across 48 test files,
covering liberty, search, sdc, spice, network, parasitics, util,
and verilog modules.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Remove unnecessary catch blocks from Tcl tests across all modules
2d27624 
Remove bare catch blocks that silently swallowed errors instead of
properly testing them. Fix underlying issues revealed by catch removal
including wrong API calls ([$role name] on strings, invalid properties
like cell_leakage_power/is_register, nonexistent Tcl bindings) and
incorrect library names. Update golden .ok files to match new output.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Delete dead code from Tcl tests and remove broken write_gate_sp…
98e00b0 
…ice tests

Remove dead code blocks that reference non-exposed Tcl commands (e.g.,
sta::find_pi_pole_residue) and delete all write_gate_spice catch blocks
from spice tests since write_gate_spice_cmd SWIG binding is missing,
making all write_gate_spice calls always fail. Added bug report for the
missing binding. All 6531 tests pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jhkim-pii @claude
test: Remove empty-body assertions and fix test issues from review fe…
e5d8d8c 
…edback

Remove useless empty-body if-blocks that check file size/existence without
doing anything, replacing them with meaningful puts output where appropriate.
Split monolithic verilog test files into individual per-test files with
their own .ok golden files. Update .ok files to match actual output.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
test: Strengthen C++ test assertions with meaningful checks
0693e7d 
Replace empty-body checks and trivial file-existence assertions with
actual content verification and state validation in C++ unit tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
test: Improve test assertions and stabilize multimodule write test
76b12eb 
Strengthen C++ test assertions in TestSdc and TestSearch with actual
value checks. Stabilize verilog_multimodule_write by using clear_sta
for isolated roundtrips. Add report_checks to wireload model tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
test: improve test stability and assertions
b55fcab 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
test: load ECSM liberty from checked-in file
10104f8 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
test: add explicit assertions to all cpp test cases
a58d7e4 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
test: remove empty if-bodies and meaningless status prints
e0f47a9 
Negate conditions in empty if-body assertions so the FAIL message
is printed directly (e.g. `if { $x != 0 } { } else { puts FAIL }`
becomes `if { $x == 0 } { puts FAIL }`).  Remove dead if/else blocks
where both branches were empty, strip meaningless status-only puts
from Tcl tests and their .ok golden files, and wrap a long line in
search_report_gated_datacheck.tcl to stay within 80 columns.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
test: strengthen liberty and verilog test assertions
c72a42e 
Add meaningful verification to liberty ECSM, sky130 corners, writer,
and roundtrip tests. Expand verilog specify, escaped-write, remove-cells,
write, and writer tests with content checks, roundtrip validation, and
error guards. Update corresponding .ok golden files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
test: strengthen assertions, add sorted SDC diff, and clean up tests
b6d598a 
- Add diff_files_sorted to test/helpers.tcl for hash-order-independent
  SDC comparison (fixes non-deterministic write_sdc output ordering)
- Use diff_files_sorted in sdc_derate_disable_deep and
  sdc_port_delay_advanced tests
- Remove stale coverage percentages from test comments (Comment 1)
- Remove unnecessary catch blocks in search property tests (Comment 3)
- Strengthen load-only tests with actual data verification (Comment 8)
- Remove orphan .ok files for deleted monolithic tests (Comment 9)
- Add golden .sdcok/.libok/.vok/.sdfok files for SDC/liberty/verilog
  write-and-diff tests
- Add -B (clean rebuild) option to make_coverage_report.sh
- Replace (void) casts and EXPECT_TRUE(true) with real assertions in
  TestSdc.cc and TestVerilog.cc

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Refactor test suites and strengthen cpp test assertions
a242c3f
@jhkim-pii @claude
test: strengthen assertions, add sorted SDC diff, and clean up tests
7173c10 
- Split oversized test files to stay under 5,000 lines per file:
  TestSdc.cc → TestSdcClasses.cc, TestSdcStaInit.cc, TestSdcStaDesign.cc
  TestSearchStaDesign.cc → TestSearchStaDesign.cc, TestSearchStaDesignB.cc
  TestLibertyStaBasics.cc → TestLibertyStaBasics.cc, TestLibertyStaBasicsB.cc
  TestNetwork.cc → TestNetwork.cc, TestNetworkB.cc
- Replace ~200+ (void) casts with proper EXPECT_* assertions across all
  C++ test files (dcalc, liberty, network, sdc, search, power, spice, util)
- Remove ~55 SUCCEED() and EXPECT_TRUE(true) no-op assertions
- Fix 6 load-only Tcl tests by adding diff_files verification with
  22 new .sdcok golden reference files
- Delete 7 orphan .ok files with no matching .tcl tests
- Add how_to_write_good_tests.md and TODO6.md documenting test quality rules

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Merge upstream STA update and adapt all tests to new API
8adbcc0 
Major upstream refactoring: Corner→Scene, Mode architecture, warning
format change (Warning ID:), command renames, and many API signature
changes. Adapted all C++ test files and TCL test scripts/expected
output files to pass with the new API. 6159/6159 tests pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Remove accidentally committed non-source files from tracking
bc728e1 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
test: harden module Tcl coverage tests
b98c2d0 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
jhkim-pii and others added 3 commits March 20, 2026 21:56
@jhkim-pii
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
992a1dc 
…ate/OpenSTA into secure-sta-test-by-opus

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
fix regression failures after master merge
0364fad 
- Remove deprecated report_net -connections/-verbose flags from tests
  (removed upstream in 7668e43)
- Regolden numerical precision diffs in parasitics and util tests

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
test: remove tests that pass nullptr Pin to PinIdHash-based maps
57e264f 
PinIdHash::operator()(nullptr) calls network_->id(nullptr) which
dereferences null, causing segfault in CI environments.

Removed 3 tests:
- SdcInitTest.SdcIsLeafPinNonGeneratedClockNull
- StaInitTest.IsClockSrcNoDesign
- StaInitTest.StaIsClockSrcNoDesign2

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Copy link
Copy Markdown
Contributor

jhkim-pii commented Mar 20, 2026 •
edited
Loading

@vvbandeira Currently, the following test fails in the CI.

The following tests FAILED:
	4277 - StaInitTest.StaTclInterpAccess (Failed)           cpp module_search
Errors while running CTest

But I cannot find the detailed log in the CI log.
How about running the CI with ctest --output-on-failure ... to leave the detailed failure reason in the CI log?

  • It will be helpful to catch the reason immediately.

jhkim-pii and others added 19 commits March 20, 2026 23:37
@jhkim-pii @claude
test: fix StaTclInterpAccess failure in Release builds
9b7c99d 
Sta::tcl_interp_ is not initialized in the constructor, so
tclInterp() returns garbage before setTclInterp() is called.
The assertion `before == nullptr` fails in Release builds where
memory is not zero-initialized.

Remove the read of uninitialized tcl_interp_ and the assertion.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge branch 'master' of https://github.com/parallaxsw/OpenSTA
8868609 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
update test files for upstream API refactoring
aac881a 
Adapt all cpp/tcl test files to match upstream OpenSTA API changes:
- string* output params changed to string return values (Verilog, Network)
- Report methods renamed (reportLineString->reportLine, printf->std::format)
- Delay type refactored from float typedef to class (Graph)
- Liberty model APIs updated (value semantics, shared_ptr, PocvMode)
- EXPECT_STREQ -> EXPECT_EQ for std::string returns (Sdc, Search)
- streamPrint -> sta::print with std::format specifiers (Spice)
- Avoid unset_clock_groups -all path (upstream iterator invalidation bug)

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge remote-tracking branch 'opensta/master' into secure-sta-test-by…
43bca8d 
…-opus

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge remote-tracking branch 'origin/secure-bump-opensta-0321' into s…
9547bee 
…ecure-sta-test-by-opus

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Fix test suite for upstream API changes after merge
434246a 
Adapt all C++ and Tcl tests for upstream API refactoring:
- Header rename: DelayFloat.hh -> Delay.hh
- PocvMode enum replacing boolean pocv (setPocvEnabled -> setPocvMode)
- setReportPathFields gains 8th parameter (report_src_attr)
- GateTableModel/CheckTableModel constructor wraps in TableModels
- gateDelay/checkDelay signature changes (bool -> MinMax/PocvMode)
- Unit::asString returns std::string instead of const char*
- ExceptionThru/To::asString removed, use to_string
- GroupPath/FilterPath/LoopPath::asString removed
- PathEnd::source_clk_delay -> source_clk_latency
- report_net -connections flag removed
- set_report_path_field_width removed
- MaxSkewCheck::skew() now requires sta parameter
- Remove tests that pass nullptr to PinIdHash-based maps (segfault)
- Remove tests for removed APIs (sigmaFactor, reportSigmas)
- Regolden .ok files for numerical precision and format changes

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
422f774 
…ate/OpenSTA into secure-sta-test-by-opus

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Fix spice tests for upstream write_path_spice API change
2b80a22 
Replace removed -spice_directory flag with -spice_file in all 7
spice test scripts to match the upstream API refactoring.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Fix non-deterministic SDC write ordering in tests
0a3368e 
Use diff_files_sorted for SDC golden file comparisons in
disable_case and write_roundtrip_full tests. The upstream
set_min_pulse_width output ordering is non-deterministic
due to hash map iteration, causing intermittent CI failures.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
069de04 
…ate/OpenSTA into secure-sta-test-by-opus

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge remote-tracking branch 'opensta/master' into secure-sta-test-by…
b42e064 
…-opus

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>

# Conflicts:
#	test/get_filter.ok
@jhkim-pii @claude
Adapt test files to upstream API changes (string_view migration)
3ca78b1 
Update 16 test files to match upstream OpenSTA API refactoring:
- const char* → std::string/std::string_view across all test APIs
- EXPECT_STREQ → EXPECT_EQ for std::string/string_view returns
- nullptr → "" for string_view parameters (makeClock, makeClockGroups, etc.)
- PropertyValue("literal") → PropertyValue(std::string("literal")) to avoid
  bool constructor overload resolution
- Method renames: relatedGroundPin→relatedGroundPort,
  relatedPowerPin→relatedPowerPort, firstName→firstParam,
  secondName→secondParam
- Constructor changes: OperatingConditions (5-arg → 1-arg + setters),
  ModeDef::defineValue (3-arg → 1-arg + setSdfCond)
- LibertyAttrValue::floatValue returns std::pair<float,bool> now
- Filter API: separate args → single expression string + bool_props_as_int
- SDF version golden files: 3.0.1 → 3.1.0

All 6104 tests pass.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Ignore SDF VERSION in diff_files to stabilize tests
14af24b 
Add (VERSION pattern to diff_files ignore parameter so SDF tests
don't break on every upstream version bump. Update golden .ok files
to reflect the now-clean diffs.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…
61bdb83 
…ate/OpenSTA into secure-sta-test-by-opus

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Stabilize tests against non-deterministic ordering and version changes
d3454bc 
- Use diff_files_sorted for exception_override_priority SDC comparisons
  to handle non-deterministic write_sdc output ordering across environments
- Add (VERSION ignore pattern to SDF diff_files calls so tests don't
  break on upstream version bumps

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Revert "Stabilize tests against non-deterministic ordering and versio…
0e5f14e 
…n changes"

This reverts commit d3454bc.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge remote-tracking branch 'opensta/master' into secure-sta-test-by…
ea22794 
…-opus

# Conflicts:
#	liberty/TableModel.cc

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii
Merge remote-tracking branch 'origin/master' into secure-sta-test-by-…
a22112f 
…opus

# Conflicts:
#	verilog/test/CMakeLists.txt

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@jhkim-pii @claude
Update golden files for upstream bias_pins feature
f192996 
Upstream added bias pin type recognition, changing VNB/VPB pin
direction from "unknown" to "bias" in liberty output. Update 9
golden .ok files to match.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
maliberty
maliberty reviewed Apr 2, 2026
View reviewed changes
Testing/Temporary/CTestCostData.txt Outdated
Copy link
Copy Markdown
Member

@maliberty maliberty Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be in this PR?

maliberty
maliberty reviewed Apr 2, 2026
View reviewed changes
Testing/Temporary/LastTest.log Outdated
Copy link
Copy Markdown
Member

@maliberty maliberty Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be in this PR?

Copy link
Copy Markdown
Contributor

@jhkim-pii jhkim-pii Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
They were committed mistakenly.
How could you find that?

@jhkim-pii
Remove temporary files
bb186c3 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@maliberty maliberty merged commit 29cea73 into The-OpenROAD-Project:master Apr 2, 2026
5 of 6 checks passed
@openroad-ci openroad-ci deleted the secure-sta-test-by-opus branch April 2, 2026 12:34
@openroad-ci openroad-ci mentioned this pull request Apr 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maliberty maliberty maliberty approved these changes

@dsengupta0628 dsengupta0628 Awaiting requested review from dsengupta0628

+1 more reviewer

@jhkim-pii jhkim-pii jhkim-pii left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jhkim-pii jhkim-pii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openroad-ci @jhkim-pii @maliberty @CLAassistant @dsengupta0628