Repository navigation
fix: resolve the PyCharm type-checker findings in price, scan and the web demo - #97
Merged
Merged
Conversation
… web demo - price: compute volatility with numpy on the dropped-NaN returns. The value is the same, and fewer than two returns give 0.0 instead of NaN. - scan: give the failure payload its own name instead of reusing the dict | None variable. - web: stop the page when a selectbox returns None, so the ticker lookup gets a str.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the 4
PyTypeCheckerInspectionfindings from the shared PyCharm profile:price.py: compute volatility with numpy on the returns after NaNs are dropped. The value is the same as before. Fewer than two returns now give 0.0 instead of NaN.scan.py: give the failure payload its own name instead of reusing adict | Nonevariable.web/dashboard.py: fall back to the first option whenselectboxreturnsNone, so the ticker lookup always gets astr.Both dashboards render with no exceptions under
streamlit.testing.AppTest.Checks
ruff check .,mypy pulseengine/andpytestpass on this commit by itself.