Skip to content

Triangle Centers - #11201

Merged
cclauss merged 11 commits into
TheAlgorithms:masterfrom
alex-buchanan:master
Sep 13, 2026
Merged

cclauss merged 11 commits into
TheAlgorithms:masterfrom
alex-buchanan:master

Conversation

@alex-buchanan

Copy link
Copy Markdown
Contributor

Describe your change:

Provide a Way of Calculating Different Triangle Centers

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • [ X ] I have read CONTRIBUTING.md.
  • [ X ] This pull request is all my own work -- I have not plagiarized.
  • [ X ] I know that pull requests will not be merged if they fail the automated tests.
  • [ X ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ X ] All new Python files are placed inside an existing directory.
  • [ X ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ X ] All functions and variable names follow Python naming conventions.
  • [ X ] All function parameters and return values are annotated with Python type hints.
  • [ X ] All functions have doctests that pass the automated testing.
  • [ X ] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Dec 6, 2023
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Dec 6, 2023
@alex-buchanan

Copy link
Copy Markdown
Contributor Author

I'm not sure why pytest fails in the automated check, if the reviewer has any suggestions or requests on how to clear this test it would be much appreciated.

@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Dec 6, 2023
@alex-buchanan

Copy link
Copy Markdown
Contributor Author

Reviewers: Is anything still missing here? The automated tests are all passing, just waiting on a reviewer to check it off / out. Anything I can do to help?

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Sep 13, 2026
Comment thread geometry/triangle.py Outdated
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 13, 2026
@cclauss
cclauss merged commit c9a815a into TheAlgorithms:master Sep 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants