✅ Add doctests to string conversion functions - #12839
Closed
Nitin-Prata wants to merge 4 commits into
Closed
Nitin-Prata wants to merge 4 commits into
Nitin-Prata wants to merge 4 commits into
Conversation
mindaugl
approved these changes
Jul 10, 2025
lighting9999
approved these changes
Jul 12, 2025
Author
|
Hi, |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR description must mark the doctest change option to avoid automatic closure.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds and refines doctests for string conversion functions without changing runtime behavior.
Changes:
- Adds an empty-string doctest.
- Simplifies transformation examples.
- Corrects docstring wording.
File summaries
| File | Description |
|---|---|
strings/min_cost_string_conversion.py |
Updates doctest examples and documentation. |
Review note: Select “Add or change doctests?” in the pull request description.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+25
| >>> compute_transform_tables("", "", 1, 2, 3, 3) | ||
| ([[0]], [['0']]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Contributes to #9943
Closes #13601
compute_transform_tablesandassemble_transformationpython -m doctest -vChecklist: