Conversation
taljeon
marked this pull request as ready for review
September 14, 2026 20:12
Member
|
ON HOLD: Our focus is on merging or closing old pull requests before October 1st. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shrink_shell_sort.shell_sortto aComparableprotocol while preserving itslist[T] -> list[T]in-place contractTypeErrorregression matrixPart of #15234. This intentionally does not close the tracking issue.
Validation
python3 -m doctest -v sorts/shrink_shell_sort.py— 6 passedpython3 -m pytest tests/test_sorts.py sorts/shrink_shell_sort.py --doctest-modules -q— 245 passedruff 0.16.7 check .— passedruff 0.16.7 format --check .— 1,546 files already formattedgit diff --check— passedAI assistance
OpenAI Codex (
gpt-5.6-sol) assisted with the focused type/test update and verification. I reviewed the complete two-file diff and the validation results above.Describe your change
Checklist