Skip to content

fix(sorts): support comparable items in pancake sort - #15354

Closed
berlin880 wants to merge 2 commits into
TheAlgorithms:masterfrom
berlin880:fix-pancake-sort-comparable
Closed

berlin880 wants to merge 2 commits into
TheAlgorithms:masterfrom
berlin880:fix-pancake-sort-comparable

Conversation

@berlin880

Copy link
Copy Markdown

Description

Update pancake_sort to support comparable items such as strings, rather than being limited to numeric values.

Changes

  • Keep the sorting function generic with TypeVar.
  • Accept Sequence[T] as input.
  • Add a doctest demonstrating sorting strings.
  • Preserve the existing behavior for numeric values.
  • Return a list[T].

Testing

  • Ran the pancake_sort doctests.
  • Verified sorting with numeric values.
  • Verified sorting with string values.

Related Issue

This PR addresses the Pancake Sort comparable-items task.
#ISSUE-NUMBER".15234

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Sep 15, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@berlin880, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 15, 2026

@berlin880 berlin880 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant