Fix exponential search for empty collections - #15362
Open
Dhaylight1 wants to merge 2 commits into
Open
Dhaylight1 wants to merge 2 commits into
Dhaylight1 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve confirmed the issue and am formatting the fix summary in the exact PR template you shared so it’s ready to paste into the GitHub description.
Describe your change
This fix addresses a boundary bug in the exponential search implementation in exponential_search.py. The function previously accessed
sorted_collection[0]without checking whether the list was empty, which caused anIndexErrorfor empty inputs. The fix adds the required empty-list guard so the function correctly returns-1when the collection is empty, while preserving the expected behavior for valid sorted inputs.Checklist