Show target application Icon, Name, and Description in the integration dialog#411
Show target application Icon, Name, and Description in the integration dialog#411azubieta wants to merge 1 commit intoTheAssassin:masterfrom
Conversation
azubieta
force-pushed
the
feature/improve_integration_dialog
branch
from
605c805 to
35b2d95
Compare
azubieta
changed the title
…ntegration dialog
azubieta
force-pushed
the
feature/improve_integration_dialog
branch
from
35b2d95 to
9580cec
Compare
| message = message.arg(integratedAppImagesDestinationPath); | ||
| ui->message->setText(message); | ||
| } catch (appimage::core::AppImageError& error) { | ||
| // TODO: Properly handle errors |
There was a problem hiding this comment.
Ideas are welcome here!
|
I think this feature must be made optional for now. Adding third-party dependencies like this one has an impact on packaging in distros, and your desktop utils parser is not available anywhere AFAIK. |
| # main AppImageLauncher application | ||
| add_executable(AppImageLauncher main.cpp resources.qrc first-run.cpp first-run.h first-run.ui integration_dialog.cpp integration_dialog.h integration_dialog.ui) | ||
| target_link_libraries(AppImageLauncher shared PkgConfig::glib libappimage shared) | ||
| target_link_libraries(AppImageLauncher shared PkgConfig::glib libappimage shared XdgUtils::DesktopEntry) |
There was a problem hiding this comment.
Where is this dependency loaded? I presume you forgot to commit a line in some other file...?
There was a problem hiding this comment.
It comes as a dependency of libappimage
This is a dependency of libappimage so if a distro is shipping the latest libappimage is also shipping this one. |
|
I'm sorry your PR has been open for all these weeks. I am not sure I'll get to reviewing it any soon. Please don't be disappointed. I'm busy with other things than my open-source work at the moment. Things will relax in a couple of months. |
|
This seems like a legitimate improvement to the UI. Poke @TheAssassin. |
3 participants
This is an attempt to include the application information in the "Integration Dialog". It uses the information contained in the Desktop file.
Related to #150