Improvement/simple range slider#72
Conversation
…l-max-elements Configurable Empty State Threshold for CMSFilter
There was a problem hiding this comment.
Pull request overview
This PR introduces a new RangeSliderSimple module (native dual-range inputs) to address slider drag/handle usability, and updates documentation + tests around range sliders and related utilities. It also adjusts a couple of Webflow-only scripts to behave consistently in jsdom-based tests and improves CI coverage reporting.
Changes:
- Added
Dist/Functional/RangeSliderSimple.js(native-thumb dual-handle slider) plus docs and Jest tests. - Refactored
Dist/Functional/RangeSlider.jsto be self-contained and added Jest tests. - Documentation formatting updates across multiple script docs; minor adjustments to CI coverage artifact/summary and
.gitignore.
Reviewed changes
Copilot reviewed 21 out of 27 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds guidance + jsDelivr examples for RangeSlider vs RangeSliderSimple |
| package-lock.json | Updates lockfile package version to 1.0.0 |
| docs/WebflowOnly/TabsSlider.md | Formatting/whitespace tweaks |
| docs/WebflowOnly/RenderStatic.md | Formatting/whitespace tweaks |
| docs/WebflowOnly/MirrorClick.md | Formatting/whitespace tweaks |
| docs/WebflowOnly/HideContainer.md | Formatting/whitespace tweaks |
| docs/WebflowOnly/CMSSelect.md | Formatting/whitespace tweaks |
| docs/WebflowOnly/CMSFilter.md | Formatting/whitespace tweaks |
| docs/Functional/ShareLink.md | Formatting/whitespace tweaks |
| docs/Functional/ReadTime.md | Formatting/whitespace tweaks |
| docs/Functional/RangeSliderSimple.md | New documentation for RangeSliderSimple |
| docs/Functional/RangeSlider.md | Updates RangeSlider docs and links to RangeSliderSimple |
| docs/Functional/Marquee.md | Formatting/whitespace tweaks |
| docs/Functional/FormCheck.md | Formatting/whitespace tweaks |
| docs/Functional/FormatNumbers.md | Formatting/whitespace tweaks |
| docs/Functional/DateCountDown.md | Formatting/whitespace tweaks |
| docs/Functional/CountUp.md | Formatting/whitespace tweaks |
| docs/Functional/CopyToClipboard.md | Formatting/whitespace tweaks |
| docs/Functional/CookieConsent.md | Formatting/whitespace tweaks |
| Dist/WebflowOnly/CMSSelect.js | Uses textContent/trim for option text to stabilize behavior in jsdom |
| Dist/WebflowOnly/CMSFilter.js | Uses textContent for result count to stabilize behavior in jsdom |
| Dist/Functional/RangeSliderSimple.js | Adds new native-thumb dual-handle slider implementation |
| Dist/Functional/RangeSlider.js | Makes RangeSlider self-contained + adds CommonJS export for tests/bundlers |
| .gitignore | Ignores coverage/ output |
| .github/workflows/tests.yml | Uploads coverage artifacts + job summary only when coverage exists |
| tests/RangeSliderSimple.test.js | Adds basic Jest coverage for RangeSliderSimple initialization/global registration |
| tests/RangeSlider.test.js | Adds basic Jest coverage for RangeSlider initialization/global registration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@matthewcsimpson Looks good but let's just test that the update adding Number instead of parseInt is working properly. it will be the user's problem if they want int or float but we should be able to handle both. |
All the feedback pieces resolved and the tests all pass. |
New Feature: RangeSliderSimple
Description
Adds RangeSliderSimple, which uses browser native handles instead of custom elements.
Also updated the failing tests on
CMSFilterandCMSSelectDEMO
https://codepen.io/matthewcsimpson/pen/myrwZgb
Related Issues
closes #71
Checklist
developbranch.Additional Notes
This pull request introduces new documentation and automated tests for several utility scripts, as well as updates to the
README.mdto clarify usage of range slider scripts. The most important changes are the addition of Jest tests forRangeSliderandRangeSliderSimple, and comprehensive documentation forCookieConsent,CopyToClipboard,CountUp, andDateCountDown. These improvements enhance both the reliability and usability of the project.Testing improvements:
RangeSliderandRangeSliderSimple, covering initialization, attribute wiring, and global registration viawindow.webtricks. (__tests__/RangeSlider.test.js,__tests__/RangeSliderSimple.test.js) [1] [2]Documentation enhancements:
CookieConsent,CopyToClipboard,CountUp, andDateCountDownscripts. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26]README improvements:
RangeSlider.jsandRangeSliderSimple.js, and providing usage examples for both.These changes collectively improve the project's test coverage, documentation clarity, and user onboarding experience.