Skip to content

⚡ Bolt: optimize compareVersions with allocation-free parsing - #121

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
bolt/optimize-compare-versions-315863973057169575
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
bolt/optimize-compare-versions-315863973057169575

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

💡 What: Replaced array .split('.') and .map(...) allocations in compareVersions with a single-pass numeric segment parsing loop in src/lib/format.ts.
🎯 Why: compareVersions is used as a comparator in sort functions across the application (e.g., sorting mod releases in InstallModal, VersionsModal, ModDetailsModal, and DependencyPlanModal, as well as filtering changelog entries in InstalledPage). Calling .split() and .map() inside $O(N \log N)$ sort comparisons causes repeated array allocations on hot paths.
📊 Impact: Eliminates array and string allocations during version string comparisons, improving memory efficiency and sort speed during list operations.
🔬 Measurement: Verified with pnpm build (tsc && vite build) and cargo test --manifest-path src-tauri/Cargo.toml.


PR created automatically by Jules for task 315863973057169575 started by @TheDragonSoft

Eliminate array .split() and .map() allocations in compareVersions
by using a single-pass numeric segment parsing loop.

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant