Repository navigation
⚡ Bolt: optimize compareVersions with allocation-free parsing - #121
TheDragonSoft wants to merge 1 commit into
Conversation
Eliminate array .split() and .map() allocations in compareVersions by using a single-pass numeric segment parsing loop. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced array$O(N \log N)$ sort comparisons causes repeated array allocations on hot paths.
.split('.')and.map(...)allocations incompareVersionswith a single-pass numeric segment parsing loop insrc/lib/format.ts.🎯 Why:
compareVersionsis used as a comparator in sort functions across the application (e.g., sorting mod releases inInstallModal,VersionsModal,ModDetailsModal, andDependencyPlanModal, as well as filtering changelog entries inInstalledPage). Calling.split()and.map()inside📊 Impact: Eliminates array and string allocations during version string comparisons, improving memory efficiency and sort speed during list operations.
🔬 Measurement: Verified with
pnpm build(tsc && vite build) andcargo test --manifest-path src-tauri/Cargo.toml.PR created automatically by Jules for task 315863973057169575 started by @TheDragonSoft