Repository navigation
🛡️ Sentinel: Validate mod names in set_enabled and toggle_mod - #123
TheDragonSoft wants to merge 1 commit into
Conversation
Sanitize mod names in mod_store::set_enabled, mod_store::ensure_mod_entry, and the toggle_mod IPC command handler using plausible_name to prevent unvalidated mod names (such as path traversal sequences or control characters) from being written into mod-list.json. Added unit tests in mod_store.rs. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🛡️ Sentinel: Fix missing input validation on mod names when toggling mod state or writing mod-list.json entries.
plausible_namevalidation inmod_store::set_enabledandmod_store::ensure_mod_entry(src-tauri/src/core/services/mod_store.rs)plausible_namevalidation intoggle_modIPC command (src-tauri/src/commands/installed.rs)mod_store.rsverifying that invalid mod names (e.g., path traversal attempts or control characters) are rejected andmod-list.jsonremains untouched.PR created automatically by Jules for task 3133889908573388612 started by @TheDragonSoft