Skip to content

🛡️ Sentinel: Cap zip entry decompression size for info.json - #125

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/zip-decompression-limit-16436343434989343157
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/zip-decompression-limit-16436343434989343157

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

🛡️ Sentinel Security Fix:

  • Vulnerability: Unbounded decompression when reading info.json from mod zip archives could allow a malicious zip bomb or malformed zip entry to cause excessive memory consumption or denial of service (DoS).
  • Fix: Applied std::io::Read::take(10 * 1024 * 1024) to cap info.json decompression at 10 MB in both mod_store.rs and downloader.rs.
  • Verification: Verified that pnpm build completes cleanly without errors.

PR created automatically by Jules for task 16436343434989343157 started by @TheDragonSoft

…o prevent DoS

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant