Skip to content

⚡ Bolt: Optimize version comparison and list sorting comparators - #127

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
bolt/zero-alloc-version-compare-and-collator-12692912629852441691
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
bolt/zero-alloc-version-compare-and-collator-12692912629852441691

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

⚡ Bolt: Zero-allocation version comparison and collator reuse

💡 What

  1. compareVersions in src/lib/format.ts: Replaced .split('.').map(...) with a single-pass index pointer scanning character codes (charCodeAt).
  2. InstalledPage sorting in src/pages/InstalledPage.tsx: Replaced per-comparison .localeCompare(..., { sensitivity: "base" }) with a module-level Intl.Collator instance (modNameCollator.compare(...)).

🎯 Why

During list sorting (e.g. installed mods, version list sorting, dependency resolution), compareVersions and string comparisons are called repeatedly ($O(N \log N)$ times). The existing compareVersions allocated multiple arrays (split) and ran .map functions per comparison. Passing options to localeCompare creates internal Intl.Collator instances or options resolution overhead on every invocation.

📊 Impact

  • Zero-allocation compareVersions: Eliminates array allocations and string parsing allocations during version sorting and filtering.
  • Reused Intl.Collator: Prevents repeated option parsing and internal collator setup during mod sorting.
  • Improved Responsiveness: Reduces garbage collection pressure and main thread execution time during list updates.

PR created automatically by Jules for task 12692912629852441691 started by @TheDragonSoft

- Replace string split and map allocations in `compareVersions` with single-pass character code index scanning.
- Reuse a module-level `Intl.Collator` instance in `InstalledPage` to eliminate repeated collator object creation during mod list sorting.

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant