Repository navigation
⚡ Bolt: Optimize version comparison and list sorting comparators - #127
TheDragonSoft wants to merge 1 commit into
Conversation
- Replace string split and map allocations in `compareVersions` with single-pass character code index scanning. - Reuse a module-level `Intl.Collator` instance in `InstalledPage` to eliminate repeated collator object creation during mod list sorting. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
⚡ Bolt: Zero-allocation version comparison and collator reuse
💡 What
compareVersionsinsrc/lib/format.ts: Replaced.split('.').map(...)with a single-pass index pointer scanning character codes (charCodeAt).InstalledPagesorting insrc/pages/InstalledPage.tsx: Replaced per-comparison.localeCompare(..., { sensitivity: "base" })with a module-levelIntl.Collatorinstance (modNameCollator.compare(...)).🎯 Why
During list sorting (e.g. installed mods, version list sorting, dependency resolution),$O(N \log N)$ times). The existing
compareVersionsand string comparisons are called repeatedly (compareVersionsallocated multiple arrays (split) and ran.mapfunctions per comparison. Passing options tolocaleComparecreates internalIntl.Collatorinstances or options resolution overhead on every invocation.📊 Impact
compareVersions: Eliminates array allocations and string parsing allocations during version sorting and filtering.Intl.Collator: Prevents repeated option parsing and internal collator setup during mod sorting.PR created automatically by Jules for task 12692912629852441691 started by @TheDragonSoft