Repository navigation
π‘οΈ Sentinel: Fix potential zip bomb DoS in info.json decompression - #128
TheDragonSoft wants to merge 1 commit into
Conversation
β¦ DoS Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: Unbounded decompression when reading info.json from mod zip archives.
π― Impact: An untrusted or malformed zip with an oversized info.json could cause high memory consumption or OOM DoS during library scanning.
π§ Fix: Bounded reading of info.json to MAX_INFO_JSON_SIZE (2 MiB) in mod_store.rs and downloader.rs.
β Verification: Added unit test
test_oversized_info_json_rejectedin mod_store.rs and verified all 142 Rust tests pass.PR created automatically by Jules for task 17768550245595021939 started by @TheDragonSoft