Skip to content

πŸ›‘οΈ Sentinel: Fix potential zip bomb DoS in info.json decompression - #128

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
fix/bounded-zip-info-json-decompression-17768550245595021939
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
fix/bounded-zip-info-json-decompression-17768550245595021939

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Unbounded decompression when reading info.json from mod zip archives.
🎯 Impact: An untrusted or malformed zip with an oversized info.json could cause high memory consumption or OOM DoS during library scanning.
πŸ”§ Fix: Bounded reading of info.json to MAX_INFO_JSON_SIZE (2 MiB) in mod_store.rs and downloader.rs.
βœ… Verification: Added unit test test_oversized_info_json_rejected in mod_store.rs and verified all 142 Rust tests pass.


PR created automatically by Jules for task 17768550245595021939 started by @TheDragonSoft

… DoS

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant