Repository navigation
π‘οΈ Sentinel: Fix zip bomb DoS vulnerability & limit pack import size - #130
TheDragonSoft wants to merge 1 commit into
Conversation
Add bounded decompression (.take(MAX_INFO_JSON_SIZE)) when reading mod zip info.json entries to prevent zip bomb Denial of Service (DoS) and OOM crashes. Enforce MAX_PACK_CODE_LEN on Base64 pack import strings to prevent memory exhaustion. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘οΈ Sentinel Security Report
info.jsonzip entries inmod_store.rsanddownloader.rsallowed zip bombs to trigger Out-Of-Memory (OOM) process crashes. Additionally, Base64 pack imports lacked string length limits.entry.by_ref().take(MAX_INFO_JSON_SIZE)(2 MB) to limit zip decompression reads safely, and enforcedMAX_PACK_CODE_LEN(1 MB) on Base64 pack imports.info.jsondecompression. All 142 Rust unit tests passed and frontend built cleanly.PR created automatically by Jules for task 356014775587353382 started by @TheDragonSoft