Skip to content

πŸ›‘οΈ Sentinel: Fix zip bomb DoS vulnerability & limit pack import size - #130

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel-zip-bomb-dos-protection-356014775587353382
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel-zip-bomb-dos-protection-356014775587353382

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

πŸ›‘οΈ Sentinel Security Report

  • 🚨 Severity: MEDIUM / HIGH (Denial of Service / Uncontrolled Resource Consumption)
  • πŸ’‘ Vulnerability: Unbounded decompressed reading of info.json zip entries in mod_store.rs and downloader.rs allowed zip bombs to trigger Out-Of-Memory (OOM) process crashes. Additionally, Base64 pack imports lacked string length limits.
  • 🎯 Impact: Malicious or corrupted mod zip files or oversized pack code inputs could crash the Axial application process by consuming gigabytes of RAM.
  • πŸ”§ Fix: Applied entry.by_ref().take(MAX_INFO_JSON_SIZE) (2 MB) to limit zip decompression reads safely, and enforced MAX_PACK_CODE_LEN (1 MB) on Base64 pack imports.
  • βœ… Verification: Added unit tests verifying rejection of oversized pack imports and bounded info.json decompression. All 142 Rust unit tests passed and frontend built cleanly.

PR created automatically by Jules for task 356014775587353382 started by @TheDragonSoft

Add bounded decompression (.take(MAX_INFO_JSON_SIZE)) when reading mod zip info.json entries to prevent zip bomb Denial of Service (DoS) and OOM crashes.
Enforce MAX_PACK_CODE_LEN on Base64 pack import strings to prevent memory exhaustion.

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant