Skip to content

πŸ›‘οΈ Sentinel: Fix path traversal vulnerability in pack saving - #134

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/fix-pack-save-path-traversal-16792835397477577662
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/fix-pack-save-path-traversal-16792835397477577662

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Missing pack ID validation in save_pack allowed arbitrary file paths / path traversal when saving pack manifests.
🎯 Impact: An invalid pack ID containing directory traversal sequences (e.g. ../) could allow writing JSON files outside the intended profiles directory.
πŸ”§ Fix: Added valid_id(&pack.id) validation in save_pack in src-tauri/src/core/services/packs.rs, matching load_pack and delete_pack.
βœ… Verification: Added unit test save_pack_rejects_invalid_pack_id_and_path_traversal verifying path traversal, slashes, and empty IDs are rejected.


PR created automatically by Jules for task 16792835397477577662 started by @TheDragonSoft

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant