Repository navigation
🛡️ Sentinel: Fix potential zip bomb vulnerability in zip reader - #135
TheDragonSoft wants to merge 2 commits into
Conversation
Enforce a 10 MB maximum decompressed size limit on info.json entry reads across mod_store.rs and downloader.rs to mitigate zip bomb / DoS risks. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Enforce a 10 MB maximum decompressed size limit on info.json entry reads across mod_store.rs and downloader.rs to mitigate zip bomb / DoS risks. Added trait imports and verified unit test suite. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
1 participant
Prevent Zip Bomb / Denial of Service (DoS) risks during zip verification and inspection in mod_store.rs and downloader.rs by enforcing an upper limit (10 MB) when reading info.json from downloaded or local mod zip archives using .take(MAX_INFO_JSON_SIZE). Added unit test coverage for oversized info.json files.
PR created automatically by Jules for task 58259312021139365 started by @TheDragonSoft