Skip to content

🎨 Palette: Add ARIA roles to progress bars & enhance search input clear button micro-UX - #139

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
jules-1197477060324640085-7acf0711
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
jules-1197477060324640085-7acf0711

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

💡 What:

  1. Added role="progressbar", aria-valuenow, aria-valuemin, aria-valuemax, and optional label prop to ProgressBar.
  2. Updated Input component so the clear button (X) is only rendered when the input contains non-empty text.
  3. Added onClear and clearLabel props to the CommandPalette search input for instant, single-click query clearing.

🎯 Why:

  • Progress indicators throughout the app (download queue, dashboard) were invisible to screen reader users.
  • Search inputs were showing empty clear buttons when onClear was supplied, and the command palette lacked an easy way to clear search queries.

♿ Accessibility:

  • Download progress bars are now fully accessible to assistive technologies.
  • Clear action buttons are keyboard accessible and have proper aria-label labels for screen readers.

PR created automatically by Jules for task 1197477060324640085 started by @TheDragonSoft

…ar button micro-UX

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant