Repository navigation
⚡ Bolt: Optimize compareVersions single-pass segment parsing & reuse Intl.Collator in mod sorting - #140
Conversation
- Single-pass numerical segment parsing in compareVersions eliminates split and map array allocations per comparison. - Reuse module-level Intl.Collator in InstalledPage sorting comparator to avoid repeated Collator object allocations. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
⚡ Bolt: Optimize compareVersions single-pass segment parsing & reuse Intl.Collator in mod sorting
💡 What:
compareVersionsinsrc/lib/format.tsto perform a single-pass index scan with numeric segment parsing, eliminatingsplit(".")andmap(...)array allocations on every comparison.Intl.Collatorinstance insrc/pages/InstalledPage.tsxinstead of invokinga.name.localeCompare(b.name, undefined, { sensitivity: "base" })on every string comparison during list sorting.🎯 Why:
Version comparisons and list sorting occur frequently when displaying installed mods, version list options, update checks, and changelogs. Repeated array splits and
Intl.Collatorobject allocations created unnecessary main-thread garbage collection pressure during list operations.📊 Impact:
compareVersionscall.Intl.Collatorobject allocations per string comparison in list sorting.🔬 Measurement:
Verified with TypeScript compilation & Vite build (
pnpm run build) and unit assertions for version comparisons.PR created automatically by Jules for task 10466871938771964912 started by @TheDragonSoft