Skip to content

⚡ Bolt: Optimize compareVersions single-pass segment parsing & reuse Intl.Collator in mod sorting - #140

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
bolt/optimize-version-compare-and-collator-10466871938771964912
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
bolt/optimize-version-compare-and-collator-10466871938771964912

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

⚡ Bolt: Optimize compareVersions single-pass segment parsing & reuse Intl.Collator in mod sorting

💡 What:

  1. Refactored compareVersions in src/lib/format.ts to perform a single-pass index scan with numeric segment parsing, eliminating split(".") and map(...) array allocations on every comparison.
  2. Reused a single module-level Intl.Collator instance in src/pages/InstalledPage.tsx instead of invoking a.name.localeCompare(b.name, undefined, { sensitivity: "base" }) on every string comparison during list sorting.

🎯 Why:
Version comparisons and list sorting occur frequently when displaying installed mods, version list options, update checks, and changelogs. Repeated array splits and Intl.Collator object allocations created unnecessary main-thread garbage collection pressure during list operations.

📊 Impact:

  • Zero array allocations per compareVersions call.
  • Zero Intl.Collator object allocations per string comparison in list sorting.
  • Faster list sorting and comparison times, especially when sorting larger mod lists or comparing version sets.

🔬 Measurement:
Verified with TypeScript compilation & Vite build (pnpm run build) and unit assertions for version comparisons.


PR created automatically by Jules for task 10466871938771964912 started by @TheDragonSoft

- Single-pass numerical segment parsing in compareVersions eliminates split and map array allocations per comparison.
- Reuse module-level Intl.Collator in InstalledPage sorting comparator to avoid repeated Collator object allocations.

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant