Skip to content

πŸ›‘οΈ Sentinel: Enforce payload size limit on mod pack imports - #141

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/fix-pack-import-dos-size-limit-2577023773017839190
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/fix-pack-import-dos-size-limit-2577023773017839190

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM

πŸ’‘ Vulnerability: Uncontrolled resource allocation / memory exhaustion DoS vulnerability during mod pack import.

🎯 Impact: An oversized payload string passed to pack import could cause high memory consumption and application crashes.

πŸ”§ Fix: Added a 2 MB size limit (MAX_PACK_CODE_LEN) in import_pack and import_pack_base64 before parsing JSON or decoding Base64 payloads.

βœ… Verification: Added unit test base64_import_fails_on_oversized_input verifying oversized payloads are safely rejected.


PR created automatically by Jules for task 2577023773017839190 started by @TheDragonSoft

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant