Repository navigation
π‘οΈ Sentinel: [HIGH] Prevent path traversal in mod name and version validation - #143
TheDragonSoft wants to merge 1 commit into
Conversation
Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability:
plausible_nameandplausible_versionaccepted.,.., and strings containing..sequences.π― Impact: Malicious mod names or versions containing
..could cause path traversal issues when constructed into file paths or API endpoints.π§ Fix: Explicitly reject
.,.., and strings containing..inplausible_nameandplausible_version.β Verification: Ran
cargo test(142 unit tests passed, including new path traversal validation tests) andpnpm build.PR created automatically by Jules for task 3284721269290791542 started by @TheDragonSoft