Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Prevent path traversal in mod name and version validation - #143

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
fix/plausible-name-version-path-traversal-3284721269290791542
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
fix/plausible-name-version-path-traversal-3284721269290791542

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: plausible_name and plausible_version accepted ., .., and strings containing .. sequences.
🎯 Impact: Malicious mod names or versions containing .. could cause path traversal issues when constructed into file paths or API endpoints.
πŸ”§ Fix: Explicitly reject ., .., and strings containing .. in plausible_name and plausible_version.
βœ… Verification: Ran cargo test (142 unit tests passed, including new path traversal validation tests) and pnpm build.


PR created automatically by Jules for task 3284721269290791542 started by @TheDragonSoft

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant