Repository navigation
⚡ Bolt: Optimize version comparison and list sorting collation - #145
TheDragonSoft wants to merge 1 commit into
Conversation
- Replace string split and map allocations in compareVersions with a zero-allocation single-pass scanner. - Reuse a memoized Intl.Collator instance in InstalledPage to prevent repeated collator allocations on list sorting. - Add unit test suite for format and version comparison utilities. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
⚡ Bolt: Optimize version comparison and list sorting collation
💡 What:
compareVersionsinsrc/lib/format.tsto use a zero-allocation single-pass index scanner instead of string.split(".")and array.map(...).Intl.Collatorinstance insrc/pages/InstalledPage.tsxto prevent creating newIntl.Collatorinstances on every item comparison during list sorting.src/lib/format.test.ts.🎯 Why:
Sorting mod release lists and installed mod lists runs comparison callbacks frequently. Allocating arrays or creating collation objects inside sorting callbacks causes garbage collection overhead on large mod lists.
📊 Impact:
PR created automatically by Jules for task 3795807960009025533 started by @TheDragonSoft