Skip to content

πŸ›‘οΈ Sentinel: Harden mod name and version validation against path traversal - #148

Open
TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/harden-name-and-version-validation-13291120663532169464
Open

TheDragonSoft wants to merge 1 commit into
mainfrom
sentinel/harden-name-and-version-validation-13291120663532169464

Conversation

@TheDragonSoft

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Input validation for mod names and version strings (plausible_name and plausible_version) previously accepted strings containing ".." or leading/trailing dots.
🎯 Impact: Untrusted mod names or versions containing path traversal sequences ("..") could attempt path traversal when constructing API URLs, mirror download URLs, or local file names.
πŸ”§ Fix: Updated plausible_name and plausible_version to explicitly reject strings containing ".." or starting/ending with dots.
βœ… Verification: Added unit tests verifying rejection of ".." and leading/trailing dots and confirming valid mod names and semver strings are accepted. All 142 Rust tests pass and frontend build succeeds.


PR created automatically by Jules for task 13291120663532169464 started by @TheDragonSoft

…ersal

Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant