Repository navigation
🛡️ Sentinel: Add canonical path validation to mod file operations - #149
TheDragonSoft wants to merge 1 commit into
Conversation
Canonicalize target mod file paths and verify that they reside strictly inside the canonicalized mods directory using `starts_with`. This prevents path traversal and symlink escape vulnerabilities when validating or uninstalling mod zip files. Added unit tests covering path traversal rejection and symlink boundary validation. Co-authored-by: TheDragonSoft <75906592+TheDragonSoft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Potential path traversal or symlink escape when operating on mod file paths (
validated_zip_path).🎯 Impact: An attacker or malformed file path could reference files outside the designated mods directory when invoking mod file operations (e.g. uninstalling or probing mod names).
🔧 Fix: Added canonical path verification (
fs::canonicalize) tovalidated_zip_pathinsrc-tauri/src/core/services/mod_store.rs, enforcingcanonical_path.starts_with(&canonical_dir).✅ Verification: Added unit tests
validated_zip_path_accepts_valid_zip_and_rejects_traversalandvalidated_zip_path_rejects_symlink_resolving_outside_mods_dir. Ran full Rust test suite (cargo test, 143 passed) and verified build (pnpm build).PR created automatically by Jules for task 14054819924241916631 started by @TheDragonSoft