Skip to content

Makefile/CI: Add linting of github workflow files #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raghavendra-talur merged 2 commits into from
Jun 18, 2026
Merged

Makefile/CI: Add linting of github workflow files #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f29fd8b
Makefile: add github workflow checking
obnoxxx Jun 18, 2026
3f5fa14
Makefile make the lint.make target more verbose
obnoxxx Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ TARGET := easyshift

CHECKMAKE := go run github.com/checkmake/checkmake/cmd/checkmake@v0.3.2
GOLANGCI_LINT := go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1
ACTIONLINT := go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12


.DEFAULT_GOAL := build


.PHONY: check

check: lint build test
check: lint.light build test

.PHONY: lint.go.vet
lint.go.vet:
Expand All @@ -38,6 +39,9 @@ fix.go.fmt: # fix go formatting (if needed)
.PHONY: lint.go.light
lint.go.light: lint.go.vet lint.go.fmt




.PHONY: test
test: lint.go.light ## run unit tests
@go test -count=1 ./...
Expand All @@ -56,11 +60,25 @@ lint.go.full: lint.go.light lint.go.golangci
.PHONY: lint.make

lint.make:
@echo "linting the Makefile..."
@$(CHECKMAKE) $(MK_SOURCE)
@echo "the Makefile is OK."

.PHONY: lint.light

lint.light: lint.make lint.workflows lint.go.light


.PHONY: lint

lint: lint.make lint.go.light
lint: lint.make lint.workflows lint.go.full

.PHONY: lint.workflows

lint.workflows: ## lint the GitHub workflow files
@echo "linting GitHub workflows..."
@$(ACTIONLINT) -color
@echo "workflows are good."



Expand Down