fix golangci lint - #14
Merged
raghavendra-talur merged 3 commits intoJun 19, 2026
Merged
Conversation
golangci-lint v2 introduced the /v2 major-version suffix in its module path. Pinning a v2.x version against the old v1 path (github.com/golangci/golangci-lint/cmd/golangci-lint) fails to resolve because Go reinterprets the version as a subdirectory tag. Update the path to .../golangci-lint/v2/cmd/golangci-lint and bump to v2.12.2. Assisted-by: Claude Code/claude-opus-4-8 Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
With golangci-lint now resolving, it surfaces 80 issues (the defaults
capped duplicates, so the initial run only showed ~21). Address them:
errcheck:
- Exclude the fmt.Fprint* family via .golangci.yml: writes to
stdout/stderr and in-memory trace writers can't meaningfully fail,
so checking each call site is noise.
- Wrap deferred Close/Remove cleanups in `defer func() { _ = ... }()`
and discard the standalone tmp.Close() in rhcos.
staticcheck (ST1005):
- Reword error strings that began with a capital ("Phase 1...",
"Red Hat SSO ...") to start lowercase, keeping the Red Hat proper
noun intact.
- Drop the trailing period from the two verifymasterip errors.
No behavior change; build, vet, gofmt, and tests still pass.
Assisted-by: Claude Code/claude-opus-4-8
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Reflect the bump to golangci-lint v2.12.2 and the new .golangci.yml (errcheck excludes the fmt.Fprint* family). Assisted-by: Claude Code/claude-opus-4-8 Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
obnoxxx
approved these changes
Jun 19, 2026
obnoxxx
left a comment
obnoxxx
left a comment
Member
There was a problem hiding this comment.
This looks good to me, even though I'd personally prefer to allow Error messages to be allowed to start with capital letters (as sentences usually do).
Thanks so much for fixing this annoying issue with running golangci-lint!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint v2 introduced the /v2 major-version suffix in its module
path. Pinning a v2.x version against the old v1 path
(github.com/golangci/golangci-lint/cmd/golangci-lint) fails to resolve
because Go reinterprets the version as a subdirectory tag. Update the
path to .../golangci-lint/v2/cmd/golangci-lint and bump to v2.12.2.
Assisted-by: Claude Code/claude-opus-4-8
Signed-off-by: Raghavendra Talur raghavendra.talur@gmail.com