Make macOS a release-gated supported platform#1048
Merged
Conversation
8 tasks
6 tasks
Owner
Author
Review contextPR #1048 integrates CodeStory's macOS runtime, POSIX setup, packaging, and release-gate source changes into Review scopeIndependently reviewed exact head Checks and findings
Disposition
This review does not claim that public Mac assets have already been signed, notarized, published, or freshly installed. |
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Makes macOS 15+ a release-gated CodeStory platform: managed Metal and full retrieval on Apple Silicon, with native CLI/plugin/local-graph support and explicitly labelled CPU or external-embedding behavior on Intel.
What changed
retrieval_mode=fullas the manifest classification while blocking packet/search when the endpoint, process identity, or required GPU proof is invalid.Why the diff is large
The current diff is 8,717 additions and 2,167 deletions: 6,550 net lines. The size is mostly platform lifecycle and release proof, not Mac-specific application behavior:
The simplifier pass removed a brittle sentence-copy assertion, a redundant no-Compose cleanup self-test, and an environment-sensitive three-second unit-test deadline. It retained deterministic tests at the process-ownership, cache-isolation, PID-reuse, and signed-release boundaries because those are the failure modes that can corrupt user state or publish an invalid Mac asset.
How to review
codestory-cli.codestory-retrievaland the readiness broker.Verification
retrieval_mode=fullandgpu_proof=verified, offloaded 13/13 layers to Metal, completed a 14 ms embedding smoke, reused the exact native PID, blocked readiness after endpoint death, repaired successfully, passed packet/search plus CLI/plugin stdio, and cleaned all proof-owned state.Risk and release follow-up
This PR is the source-integration receipt and remains draft only until its exact-head hosted source and native-package checks pass. Parent #1046 and #887 remain open for protected Developer ID/notarization credentials, the protected Apple Silicon lifecycle workflow, signed public assets, post-publish Gatekeeper checks, and a fresh Codex marketplace install/readback.
Closes #1049
Refs #1046
Refs #887