[codex] use native process time for windows embedding snapshot#1072
Merged
TheGreenCedar merged 1 commit intoJul 13, 2026
Merged
Conversation
Owner
Author
Windows live acceptanceExact head
A second repair invocation was rejected at the existing machine-resource broker ownership gate while the proven runtime was still live; it did not reproduce the identity failure and is not widened into this snapshot fix. Proof-scoped cleanup will run immediately after merge. PR #1052 will then rebase onto the resulting |
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #1070 moved exact Windows process-start identity to
GetProcessTimes, but its exact packaged proof still failed during the later process snapshot. The snapshot continued convertingWin32_Process.CreationDatethrough the DMTF converter even though this host returns aSystem.DateTime.What Changed
OpenProcess/GetProcessTimeshelper for exact identity and snapshot start time.How To Review
Review the Windows-only path in
crates/codestory-retrieval/src/sidecar.rs. The serializedwindows:<ticks>identity, PID-reuse checks, schema, dependencies, and non-Windows behavior are unchanged.Verification
cargo test --locked -p codestory-retrieval --lib windows_native_embedding_identity_and_snapshot_are_stable_and_compatiblecargo test --locked -p codestory-retrieval --lib native_embedding(21 passed)cargo check --locked -p codestory-retrieval -p codestory-clicargo clippy --locked -p codestory-retrieval --lib -- -D warningscargo fmt --all -- --checkgit diff --checkNo UI change; visual evidence does not apply.
Risk
Low and Windows-only. Access/query errors remain fail-closed, and only a confirmed missing PID returns
None. Exact packaged Windows x64 Vulkan proof remains the merge acceptance.Closes #1071
Refs #1052